Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in comments for Convert #193

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Align Intellisense comment with full .NET docs.
  • Reword remarks to clarify specificity of .NET nanoFramework implementation.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Align Intellisense comment with full .NET docs.
- Reword remarks to clarify specificity of .NET nanoFramework implementation.
@josesimoes josesimoes added the ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. label Nov 18, 2022
@josesimoes josesimoes marked this pull request as draft November 18, 2022 10:27
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much more clear to me :-) Waiting for a native speaker to double check :-)

@networkfusion
Copy link
Member

LGTM!

@networkfusion networkfusion marked this pull request as ready for review November 19, 2022 16:52
@josesimoes josesimoes marked this pull request as draft November 21, 2022 07:24
@josesimoes
Copy link
Member Author

@rkalwak looks like we're good to go with this. Are you still up to updating the comments for the other convert methods? 😃

@josesimoes josesimoes removed ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. Status: in progress labels Dec 2, 2022
@josesimoes josesimoes marked this pull request as ready for review December 2, 2022 19:38
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@josesimoes josesimoes merged commit 7023773 into main Dec 2, 2022
@josesimoes josesimoes deleted the reword-convert-remarks branch December 19, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants