Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in ToUint32 and ToUint64 description #201

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

cbagpipe
Copy link
Contributor

Description

  • ToUint32() & ToUint64() comments says it will be converted from TWO bytes. Changed to "four" and "eight" respectively.

Motivation and Context

  • It confuses.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

ToUint32 & ToUint64 comment says it converted from TWO bytes. Changed to "four" and "eight" respectively.
@nfbot nfbot changed the title Fixed copy/paste typo in methods description. Fixed copy/paste typo in methods description Jan 12, 2023
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks. 👍🏻

@josesimoes josesimoes changed the title Fixed copy/paste typo in methods description Fixed typo in ToUint32 and ToUint64 description Jan 12, 2023
@josesimoes josesimoes enabled auto-merge (squash) January 12, 2023 09:16
@josesimoes josesimoes enabled auto-merge (squash) January 12, 2023 09:25
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josesimoes josesimoes merged commit 02509b3 into nanoframework:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants