Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor should copy only the desired chars #24

Merged
merged 2 commits into from
Sep 12, 2018

Conversation

MatthiasJentsch
Copy link
Contributor

Description

If startIndex is not zero and length not value.length the last line in the constructor would throw an exception.

Motivation and Context

Found that during unit testing

How Has This Been Tested?

With this change the call StringBuilder sb = new StringBuilder("nanoFramework", 4, 5, 7) works correctly. Without this change the call throws an exception.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch info@matthias-jentsch.de

If startIndex is not zero and length not value.length the last line in the constructor would throw an exception.
@nfbot
Copy link
Member

nfbot commented Sep 4, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes added Type: bug ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. labels Sep 4, 2018
@josesimoes josesimoes removed the ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. label Sep 12, 2018
@josesimoes josesimoes merged commit d66b36d into nanoframework:develop Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants