Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetCustomAttributes method to MemberInfo and derived classes #27

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Add GetCustomAttributes method to MemberInfo and derived classes #27

merged 1 commit into from
Sep 28, 2018

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • Allows accessing custom attributes in classes and methods.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: enhancement ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. labels Sep 27, 2018
@nfbot
Copy link
Member

nfbot commented Sep 27, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 27, 2018
@josesimoes
Add support for GetCustomAttributes
e67fe4b 
- Add GetCurrent function to CLR_RT_AttributeEnumerator
- Fix bug in CLR_RT_AttributeEnumerator::Initialize
- Add code to support nanoframework/CoreLibrary#27

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Sep 27, 2018
Merged
10 tasks
@josesimoes
Add GetCustomAttributes method to MemberInfo and derived classes
82662a6 
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 28, 2018
@josesimoes
Add support for GetCustomAttributes
86614ca 
- Add GetCurrent function to CLR_RT_AttributeEnumerator
- Fix bug in CLR_RT_AttributeEnumerator::Initialize
- Add code to support nanoframework/CoreLibrary#27

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes removed the ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. label Sep 28, 2018
@josesimoes josesimoes merged commit 05aa51b into nanoframework:develop Sep 28, 2018
@josesimoes josesimoes deleted the add-GetCustomAttributes branch September 28, 2018 08:58
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 28, 2018
@josesimoes
Add support for GetCustomAttributes
e3762c9 
- Add GetCurrent function to CLR_RT_AttributeEnumerator
- Fix bug in CLR_RT_AttributeEnumerator::Initialize
- Add code to support nanoframework/CoreLibrary#27

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot