Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryParseGuidWithDashes added along with string based constructor. #88

Merged
merged 4 commits into from
Sep 27, 2019
Merged

TryParseGuidWithDashes added along with string based constructor. #88

merged 4 commits into from
Sep 27, 2019

Conversation

Roadrunner67
Copy link
Contributor

@Roadrunner67 Roadrunner67 commented Sep 25, 2019 •
edited by josesimoes
Loading

Description

  • Additional constructor from Guid string added which uses TryParseGuidWithDashes (also public).

Motivation and Context

How Has This Been Tested?

This change was tested as part of a .Net Standard project, and ported to nanoFramework.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Roadrunner67sbc@bangding.dk

@nfbot
Copy link
Member

nfbot commented Sep 25, 2019

Hi @Roadrunner67,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Roadrunner67 Roadrunner67 mentioned this pull request Sep 26, 2019
Closed
@Roadrunner67
Copy link
Contributor Author

Will need to work a little on that :-|

@josesimoes
Copy link
Member

SonarCloud failing on code coverage. Ignoring.

josesimoes
josesimoes approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@josesimoes
Copy link
Member

Sonarcloud failing on code coverage. OK to ignore.

@josesimoes josesimoes merged commit 7e9a5a0 into nanoframework:develop Sep 27, 2019
@Roadrunner67 Roadrunner67 deleted the issue/514 branch September 27, 2019 13:46
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 16, 2019
@josesimoes
Update mscorlib assembly declaration
33856d8 
- Following nanoframework/CoreLibrary#88.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Oct 16, 2019
Merged
10 tasks
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 16, 2019
@josesimoes
Update mscorlib assembly declaration
c42e0ec 
- Following nanoframework/CoreLibrary#88.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 16, 2019
@josesimoes
Update mscorlib assembly declaration
199b388 
- Following nanoframework/CoreLibrary#88.

***PUBLISH_RELEASE***
***UPDATE_DEPENDENTS***

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Oct 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guid.ToString() changes byte order
4 participants
@Roadrunner67 @nfbot @CLAassistant @josesimoes