Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract ResourceManager class #92

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Extract ResourceManager class #92

merged 1 commit into from
Oct 18, 2019

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Oct 18, 2019 •
edited
Loading

Description

  • Moved to ResourceManager nanoFramework.ResourceManager class library.
  • Update friends class with nanoFramework.ResourceManager.
  • Bump AssemblyNativeVersion to 100.4.0.0.

Motivation and Context

  • Move all the API to use managed resources into a single class library. As it is now requires referencing mscorlib and Runtime.Native.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes self-assigned this Oct 18, 2019
@nfbot
Copy link
Member

nfbot commented Oct 18, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Extract ResourceManager class. Extract ResourceManager class Oct 18, 2019
@josesimoes
Extract ResourceManager class.
216b237 
- Moved to nanoFramework.ResourceManager class library.
- Update friends class.
- Bump AssemblyNativeVersion to 100.4.0.0.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit ef16d48 into nanoframework:develop Oct 18, 2019
@josesimoes josesimoes deleted the extract-resourcemanager branch October 18, 2019 13:10
@josesimoes josesimoes mentioned this pull request Oct 18, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@josesimoes josesimoes

Labels
Breaking-Change Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot