Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetDevicePublicKey #265

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aromaa
Copy link

@aromaa aromaa commented Jul 21, 2022

Description

  • Adds GetDevicePublicKey.
  • Bump version.

Motivation and Context

  • Allows developers to get the public key from the device certificate store.

How Has This Been Tested?

  • Locally by calling CertificateManager.GetDevicePublicKey().

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@nfbot nfbot added the Type: enhancement New feature or request label Jul 21, 2022
@josesimoes
Copy link
Member

@aromaa
Copy link
Author

aromaa commented Jul 21, 2022

I was picturing this living in in the X502Cert class

Isn't that a bit funny? The certificate itself shouldn't know about how/where to retrieve certificates. The CertificateManager is already dealing with the certificate store so it seems like the most obvious place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants