-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AES CBC #6
Add AES CBC #6
Conversation
Added Unit Tests for CBC using the NIST data and following Unit tests ECB. Also made small change to logic so IV is not automatically randomly filled. For this you need to call GenerateIV() else IV will be filled with 0x00. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition. I guess the intellisense comments and the function definitions are aligned wtih .NET?
Quality Gate passedIssues Measures |
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (8)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
- Now setting backing fields instead of properties. - When CBC calling GenereteIV.
- Split ECB and CBC tests. - Fix failing ECB test related with exceptions returning from the native code. - Rename cyphers and test vectors for CBC. - Fix NIST test vectors for CBC. - Fix NIST test results for CBC. - Remove unused code. - Update README.
Quality Gate passedIssues Measures |
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: