Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework PSRAM detection #270

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Rework FindPSRamAvailable so that PSRAM detection is now performed by analyzing the bootloader output
  • Add parameter to force uploading a test app.
  • Update bootloader and test app from library folder.
  • Add new option to request specifically to test PSRAM availability.
  • Update code accordingly.
  • On PSRAM available, parses size of it.
  • ESP32 device details now output PSRAM size if available.

Motivation and Context

  • Significantly decreases complexity to check for PSRAM on daily usage: no need to upload test app (which was destructive of NV storage contents). Only requirement (which should be pretty acceptable) is that the device has been flashed previously with a nanoFramework image.
  • Adds option to force PSRAM check which uploads a test app.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Rework FindPSRamAvailable so that PSRAM detection is now performed by analysing the bootloader output
- Add parameter to force uploading a test app.
- Update bootloader and test app from library folder.
- Add new option to request specifically to test PSRAM availability.
- Update code accordingly.
- On PSRAM available, parses size of it.
- ESP32 device details now output PSRAM size if available.
Copy link

coderabbitai bot commented May 28, 2024

Important

Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (21)
  • README.md is excluded by !**/*.md and included by none
  • README.zh-cn.md is excluded by !**/*.md and included by none
  • lib/esp32bootloader/bootloader.bin is excluded by !**/*.bin and included by none
  • lib/esp32bootloader/partitions_16mb.bin is excluded by !**/*.bin and included by none
  • lib/esp32bootloader/partitions_2mb.bin is excluded by !**/*.bin and included by none
  • lib/esp32bootloader/partitions_8mb.bin is excluded by !**/*.bin and included by none
  • lib/esp32bootloader/test_startup.bin is excluded by !**/*.bin and included by none
  • lib/esp32s2bootloader/bootloader.bin is excluded by !**/*.bin and included by none
  • lib/esp32s2bootloader/partitions_16mb.bin is excluded by !**/*.bin and included by none
  • lib/esp32s2bootloader/partitions_2mb.bin is excluded by !**/*.bin and included by none
  • lib/esp32s2bootloader/partitions_4mb.bin is excluded by !**/*.bin and included by none
  • lib/esp32s2bootloader/partitions_8mb.bin is excluded by !**/*.bin and included by none
  • lib/esp32s2bootloader/test_startup.bin is excluded by !**/*.bin and included by none
  • lib/esp32s3bootloader/bootloader.bin is excluded by !**/*.bin and included by none
  • lib/esp32s3bootloader/partitions_4mb.bin is excluded by !**/*.bin and included by none
  • lib/esp32s3bootloader/test_startup.bin is excluded by !**/*.bin and included by none
  • nanoFirmwareFlasher.Library/Esp32DeviceInfo.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/EspTool.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/nanoFirmwareFlasher.Library.csproj is excluded by none and included by none
  • nanoFirmwareFlasher.Tool/Esp32Manager.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Tool/Options.cs is excluded by none and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@josesimoes josesimoes merged commit cf43d26 into nanoframework:main May 28, 2024
4 checks passed
@josesimoes josesimoes deleted the rework-psram-detection branch May 28, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants