Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to .NET 8.0 #277

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Migrate to .NET 8.0 #277

merged 1 commit into from
Jun 14, 2024

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jun 14, 2024

Description

  • Update project targets.
  • Update/migrate code accordingly.
  • Minor code improvements following code analysis.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Summary by CodeRabbit

  • Chores
    • Updated dependency versions from net6.0 to net8.0 for improved compatibility and performance.
    • Removed unnecessary dependencies to streamline the application.

- Update project targets.
- Update/migrate code accordingly.
- Minor code improvements following code analysis.
Copy link

coderabbitai bot commented Jun 14, 2024

Walkthrough

The updates to the nanoFirmwareFlasher.Library/packages.lock.json and nanoFirmwareFlasher.Tool/packages.lock.json primarily involve upgrading the target framework from net6.0 to net8.0 and removing the System.Runtime.CompilerServices.Unsafe dependency. These changes ensure compatibility with the latest .NET versions and improve overall dependency management.

Changes

File Path Change Summary
nanoFirmwareFlasher.Library/packages.lock.json Updated target framework from net6.0 to net8.0, removed System.Runtime.CompilerServices.Unsafe.
nanoFirmwareFlasher.Tool/packages.lock.json Updated target framework from net6.0 to net8.0, removed System.Runtime.CompilerServices.Unsafe.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
nanoFirmwareFlasher.Library/packages.lock.json (1)

[!TIP]
Codebase Verification

The script output indicates that the nanoFirmwareFlasher.Tests/nanoFirmwareFlasher.Tests.csproj file still references net6.0. This suggests that not all project files have been updated to .NET 8.0.

  • nanoFirmwareFlasher.Tests/nanoFirmwareFlasher.Tests.csproj: <TargetFramework>net6.0</TargetFramework>

Please update this file to target .NET 8.0 to ensure consistency across the project.

Analysis chain

Line range hint 272-428: The migration from .NETFramework,Version=v4.7.2 to net8.0 appears to be correctly reflected in the dependencies with updated versions. However, it's crucial to ensure that all other parts of the project and any dependent projects or services are also compatible with these changes.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that all project files and dependent services have been updated to .NET 8.0.

# Test: Search for any remaining references to older .NET versions.
rg --type csproj --type sln "net6.0|netcoreapp3.1|net5.0"

Length of output: 90



Script:

#!/bin/bash
# Description: Verify that all project files and dependent services have been updated to .NET 8.0.

# Test: Search for any remaining references to older .NET versions.
rg "net6.0|netcoreapp3.1|net5.0"

Length of output: 139

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0c647eb and d4215c7.

Files ignored due to path filters (18)
  • nanoFirmwareFlasher.Library/CC13x26x2Firmware.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/CC13x26x2Operations.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/Esp32Firmware.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/Esp32Operations.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/FileDeployment/FileDeploymentManager.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/FirmwarePackage.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/JLinkCli.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/JLinkDevice.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/JLinkOperations.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/NanoDeviceOperations.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/Stm32Operations.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/StmDfuDevice.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/StmJtagDevice.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Library/nanoFirmwareFlasher.Library.csproj is excluded by none and included by none
  • nanoFirmwareFlasher.Tool/Options.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Tool/Program.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Tool/SilabsManager.cs is excluded by none and included by none
  • nanoFirmwareFlasher.Tool/nanoFirmwareFlasher.Tool.csproj is excluded by none and included by none
Files selected for processing (2)
  • nanoFirmwareFlasher.Library/packages.lock.json (4 hunks)
  • nanoFirmwareFlasher.Tool/packages.lock.json (6 hunks)
Additional comments not posted (4)
nanoFirmwareFlasher.Library/packages.lock.json (1)

1254-1254: The update of System.Text.Encodings.Web to version 8.0.0 is noted and aligns with the overall migration to .NET 8.0. Ensure that this update does not introduce any breaking changes in how text encoding is handled in your application.

Verification successful

The update to System.Text.Encodings.Web version 8.0.0 does not introduce any breaking changes in your application, as there are no implemented methods in your codebase that rely on this library.

  • The methods DecodePackageDetails and DecodePackageInformation in nanoFirmwareFlasher.Tests/CloudsmithApiTests.cs are stubs and do not contain any actual implementation.
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that the update to System.Text.Encodings.Web 8.0.0 does not introduce breaking changes.

# Test: Check for custom encoders or decoders that might be affected by the new version.
rg --type cs "System.Text.Encodings.Web"

Length of output: 40



Script:

#!/bin/bash
# Description: Verify that the update to System.Text.Encodings.Web 8.0.0 does not introduce breaking changes.

# Test: Check for encoding or decoding methods that might be affected by the new version.

# Search for encoding methods
rg --type cs "Encode"

# Search for decoding methods
rg --type cs "Decode"

Length of output: 229



Script:

#!/bin/bash
# Description: Extract the implementation of decoding methods in nanoFirmwareFlasher.Tests/CloudsmithApiTests.cs.

# Extract implementation of DecodePackageDetails
rg --type cs -A 10 "public void DecodePackageDetails" nanoFirmwareFlasher.Tests/CloudsmithApiTests.cs

# Extract implementation of DecodePackageInformation
rg --type cs -A 10 "public void DecodePackageInformation" nanoFirmwareFlasher.Tests/CloudsmithApiTests.cs

Length of output: 546

nanoFirmwareFlasher.Tool/packages.lock.json (3)

Line range hint 4-114: Dependencies updated. Verify that the removal of System.Runtime.CompilerServices.Unsafe does not impact project functionality.


4-4: Update to .NET 8.0 confirmed. Ensure all dependencies are compatible with .NET 8.0.


Line range hint 991-1683: Updates to System.Text.Encodings.Web and System.Threading.Tasks look correct. Please ensure the content hashes match the official sources.

@josesimoes josesimoes merged commit 0d2f7b4 into nanoframework:main Jun 14, 2024
4 checks passed
@josesimoes josesimoes deleted the udpate-to-NET8.0 branch June 14, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants