Rework on build tasks #298
Conversation
nfbot
added
Type: bug
WalkthroughThe changes remove the build steps related to the Changes
Sequence Diagram(s)(No sequence diagrams are necessary for these changes as they are purely configuration-related.) Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (6)
azure-pipelines.yml (6)
Line range hint
24-25: Remove trailing spaces to adhere to YAML best practices.- branches: - include: + branches: + include:
Line range hint
72-72: Remove trailing spaces to maintain YAML file cleanliness.- - script: npm ci + - script: npm ci
Line range hint
82-82: Remove trailing spaces to ensure YAML syntax accuracy.- - script: npm run build:prod + - script: npm run build:prod
Line range hint
94-94: Remove trailing spaces to avoid potential YAML parsing issues.- - pwsh: | + - pwsh: |
Line range hint
115-115: Remove trailing spaces to enhance the readability and maintainability of the YAML file.- - template: azure-pipelines-templates/discord-webhook-task.yml@templates + - template: azure-pipelines-templates/discord-webhook-task.yml@templates
Line range hint
140-140: Remove trailing spaces on these lines to align with best practices for YAML files.- - task: CopyFiles@2 + - task: CopyFiles@2 - - task: PublishBuildArtifacts@1 + - task: PublishBuildArtifacts@1Also applies to: 180-180
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (7)
.gitmodulesis excluded by none and included by noneREADME.mdis excluded by!**/*.mdand included by noneinstallation.mdis excluded by!**/*.mdand included by nonenanoFirmwareFlasheris excluded by none and included by nonescripts/build.ps1is excluded by none and included by nonesrc/dotnet.tsis excluded by none and included by nonesrc/extension.tsis excluded by none and included by none
Files selected for processing (1)
- azure-pipelines.yml (1 hunks)
Additional context used
yamllint
azure-pipelines.yml
[error] 24-24: trailing spaces (trailing-spaces)
[error] 25-25: trailing spaces (trailing-spaces)
[error] 72-72: trailing spaces (trailing-spaces)
[error] 82-82: trailing spaces (trailing-spaces)
[error] 94-94: trailing spaces (trailing-spaces)
[error] 115-115: trailing spaces (trailing-spaces)
[error] 140-140: trailing spaces (trailing-spaces)
[error] 180-180: trailing spaces (trailing-spaces)
- Remove dependency of local nanoFirmawareFlasher. - Replace with calls to nanoff dotnet tool. - Add installer step to extension activation. - Fix all calls to nanoff. - General improvements in all Dotnet class API: calling msbuild, generating outputs, calling nanoff to deploy and flash. - Update repo readme and developer instructions. - Update AZDO yaml to remove the build tasks and everything related with nanoff local copy.
josesimoes
force-pushed
the
remove-local-nanoff
branch
from
60f2b93
to
0403465
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
azure-pipelines.yml (2)
Line range hint
24-24: Clean up trailing spaces to maintain code quality and consistency.- # PR always trigger build + # PR always trigger build - # add nf-tools repo to resources (for Azure Pipelines templates) + # add nf-tools repo to resources (for Azure Pipelines templates) - - pwsh: scripts/build.ps1 + - pwsh: scripts/build.ps1 - - task: DeleteFiles@1 + - task: DeleteFiles@1 - - script: npm ci + - script: npm ci - - task: DotNetCoreCLI@2 + - task: DotNetCoreCLI@2 - - pwsh: | + - pwsh: | - - task: CopyFiles@2 + - task: CopyFiles@2Also applies to: 25-25, 72-72, 82-82, 94-94, 115-115, 140-140, 180-180
Line range hint
72-72: Consider removing thecondition: succeeded()from theDeleteFilestask if it's essential that this step always runs regardless of previous failures.- condition: succeeded()
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (8)
.gitmodulesis excluded by none and included by noneREADME.mdis excluded by!**/*.mdand included by noneinstallation.mdis excluded by!**/*.mdand included by nonenanoFirmwareFlasheris excluded by none and included by nonescripts/build.ps1is excluded by none and included by nonesrc/dotnet.tsis excluded by none and included by nonesrc/extension.tsis excluded by none and included by nonesrc/multiStepInput.tsis excluded by none and included by none
Files selected for processing (1)
- azure-pipelines.yml (1 hunks)
Additional context used
yamllint
azure-pipelines.yml
[error] 24-24: trailing spaces (trailing-spaces)
[error] 25-25: trailing spaces (trailing-spaces)
[error] 72-72: trailing spaces (trailing-spaces)
[error] 82-82: trailing spaces (trailing-spaces)
[error] 94-94: trailing spaces (trailing-spaces)
[error] 115-115: trailing spaces (trailing-spaces)
[error] 140-140: trailing spaces (trailing-spaces)
[error] 180-180: trailing spaces (trailing-spaces)
Additional comments not posted (3)
azure-pipelines.yml (3)
Line range hint
180-180: Ensure thePublishBuildArtifacts@1task is correctly configured to publish the intended artifacts.Verification successful
The
PublishBuildArtifacts@1task is configured to publish artifacts from the$(Build.ArtifactStagingDirectory)directory, which is the intended directory for build artifacts. This confirms that the task is correctly set up to publish the intended artifacts.
PublishBuildArtifacts@1task configuration:
ArtifactName:git-mob-vs-codePathtoPublish:$(Build.ArtifactStagingDirectory)Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all intended artifacts are being published. # Test: List all files in the artifact staging directory. ls -l $(Build.ArtifactStagingDirectory)Length of output: 1085
Script:
#!/bin/bash # Search for the PublishBuildArtifacts@1 task in the azure-pipelines.yml file rg 'PublishBuildArtifacts@1' azure-pipelines.ymlLength of output: 82
Script:
#!/bin/bash # Retrieve the configuration details of the PublishBuildArtifacts@1 task in the azure-pipelines.yml file rg -A 5 -B 5 'PublishBuildArtifacts@1' azure-pipelines.ymlLength of output: 432
Line range hint
14-14: Ensure the trigger configuration for branches is adequate for the project's workflow.
Line range hint
94-94: Thenpm citask is marked as always succeeding. Ensure this is intentional, as it may mask failures in dependency installation.Verification successful
The
npm citask is configured with the conditionsucceeded(), which means it will only run if previous tasks have succeeded. There is no indication that it is set to always succeed (continueOnErroris not present).
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that `npm ci` is configured to fail on errors. # Test: Force a failure in `npm ci` and observe if it fails the build. npm ci --force-failLength of output: 92
Script:
#!/bin/bash # Description: Locate the `npm ci` task in the `azure-pipelines.yml` file and check its configuration. # Locate the `npm ci` task rg 'npm ci' azure-pipelines.yml # Check if the task is configured to always succeed rg 'npm ci' -A 5 azure-pipelines.yml | grep 'continueOnError'Length of output: 138
Script:
#!/bin/bash # Description: Thoroughly check the configuration of the `npm ci` task in the `azure-pipelines.yml` file. # Check the surrounding lines of the `npm ci` task for any configurations that might cause it to always succeed rg -A 10 -B 10 'npm ci' azure-pipelines.ymlLength of output: 573
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit
nanoffin the Azure Pipelines configuration, streamlining the build process.