Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on native implementation for Windows.Storage #1290

Merged
merged 9 commits into from
Apr 23, 2019
Merged

Work on native implementation for Windows.Storage #1290

merged 9 commits into from
Apr 23, 2019

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Apr 21, 2019 •
edited by josesimoes
Loading

Description

StorageFolder

  • GetFolder - Required to create paths so you can call delete or rename
  • Delete
  • Rename

StorageFile

  • Delete
  • Rename

How Has This Been Tested?

  • Tested new methods on ESP32 with sample code, Chibios functions untested and needs to be reviewed/tested.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@AdrianSoundy
Add new functions to WIndows.Storage
0071422 
Folder.Delete()
Folder.Rename()
Folder.GetFolder()
File.Rename()
File.Delete()
@AdrianSoundy
Merge branch 'develop' into storage-delete-rename
7e35369
@AdrianSoundy
Added new methods to Chibios
5cb1bb5 
Untested , to be reviewed
@nfbot
Copy link
Member

nfbot commented Apr 21, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Status: in progress Type: enhancement labels Apr 22, 2019
@josesimoes josesimoes self-assigned this Apr 22, 2019
@josesimoes
Fix declarations
c076a20 
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes
Merge branch 'develop' into storage-delete-rename
57d7405
@josesimoes josesimoes changed the title Storage - Add delete,rename folder/file Work on native implementation for Windows.Storage Apr 23, 2019
@josesimoes josesimoes merged commit acbabed into nanoframework:develop Apr 23, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@josesimoes josesimoes

Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes