Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to build without complex math functions #1454

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

antoniofagundes
Copy link
Member

Description

  • Wrap calls to complex math functions and provide call to NotImplementedStub() as alternative.

Motivation and Context

  • Allows reducing the build size with optional removal of complex math calls like acos, asin, atan, exp, etc.
  • Default is false so this doesn't introduce any breaking change on any existing target.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: António Fagundesantonio.fagundes@eclo.solutions

- Allows reducing the build size with optional removal of complex math calls like acos, asin, atan, exp, etc.
- Default is false so this doesn't introduce any breaking change on any existing target.
@nfbot
Copy link
Member

nfbot commented Oct 10, 2019

Hi @antoniofagundes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: enhancement labels Oct 10, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit 9f64e96 into nanoframework:develop Oct 10, 2019
@antoniofagundes antoniofagundes deleted the patch-3 branch October 25, 2019 15:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants