Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time accuracy #1465

Merged
merged 2 commits into from
Oct 27, 2019
Merged

Fix time accuracy #1465

merged 2 commits into from
Oct 27, 2019

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Oct 27, 2019

Description

Time was only accurate to 1millisec although time from RTC should have been accurate to 1 micro sec.
This was caused by using HAL_Time_ToSystemTime which only works down to millisecs.

Now bypass HAL_Time_ToSystemTime & HAL_Time_ConvertFromSystemTime unless date only.
This also improves performance of getting time.

Motivation and Context

Want look at passing time to gpio events so the time between events can be calculated down to 1 micro secs. This is for devices like the DHT11 & DHT22 sensors.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Oct 27, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy added Series: ESP32 Everything related specifically with ESP32 series targets Area: Interpreter Everything related with the interpreter, execution engine and such labels Oct 27, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes added Type: bug and removed Area: Interpreter Everything related with the interpreter, execution engine and such labels Oct 27, 2019
@josesimoes josesimoes merged commit 0667f7b into nanoframework:develop Oct 27, 2019
@AdrianSoundy AdrianSoundy deleted the FixTime branch October 28, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants