Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Esp32 Ethernet for alternate clock modes #1526

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Update Esp32 Ethernet for alternate clock modes #1526

merged 2 commits into from
Dec 10, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Adds an configuration option to select an alternate Phy Clock mode as used by the ESP32 Olimex POE series of devices.

Motivation and Context

Support issue on forum

How Has This Been Tested?

Fixed tested by andylyonette

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Dec 10, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy added the Series: ESP32 Everything related specifically with ESP32 series targets label Dec 10, 2019
@AdrianSoundy AdrianSoundy merged commit bf214b6 into nanoframework:develop Dec 10, 2019
@AdrianSoundy AdrianSoundy deleted the Update-ethernet branch December 10, 2019 06:30
@coderabbitai coderabbitai bot mentioned this pull request Aug 4, 2024
Merged
13 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes