Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove c_Flags_Patch from CLR_RECORD_ASSEMBLY #1644

Merged
merged 1 commit into from
May 26, 2020
Merged

Remove c_Flags_Patch from CLR_RECORD_ASSEMBLY #1644

merged 1 commit into from
May 26, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Remove c_Flags_Patch from CLR_RECORD_ASSEMBLY
  • Update code accordingly.
  • Improve comments in FindAssembly.

Motivation and Context

  • This flag was inherited from .NETMF and is not used anymore.
  • Exact match of assembly version is not required. We are enforcing only major and minor.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Remove c_Flags_Patch from CLR_RECORD_ASSEMBLY
67820c7 
- Update code accordingly.
- Improve comments in FindAssembly.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries Breaking-change labels May 26, 2020
@nfbot
Copy link
Member

nfbot commented May 26, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 2e796d5 into nanoframework:develop May 26, 2020
@josesimoes josesimoes deleted the fix-findassembly branch May 26, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Breaking-change Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot