Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in ESP32 I2C #2103

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Driver is now installed in RAM.
  • Read buffer is now allocated from RAM.
  • Rework SetConfig to assert call to IDF.
  • Add assert to returns from calls to IDF.
  • Improvements in I2C handling code for efficiency.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Driver is now installed in RAM.
- Read buffer is now allocated from RAM.
- Rework SetConfig to assert call to IDF.
- Add assert to returns from calls to IDF.
- Improvements in I2C handling code for efficiency.
@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets hacktoberfest-accepted labels Oct 18, 2021
@josesimoes josesimoes merged commit 794f2fe into nanoframework:develop Oct 18, 2021
@josesimoes josesimoes deleted the work-esp3-i2c branch October 18, 2021 15:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Series: ESP32 Everything related specifically with ESP32 series targets Type: bug Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I2C not working in Firmware 1.7.1-preview.966 ESP32 I2C response data limitation
2 participants