Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dev containers regarding Python version #2697

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

Ellerbach
Copy link
Member

@Ellerbach Ellerbach commented Jul 17, 2023

Description

  • Fixing dev containers with change in python version and new IDF version.
  • Turns out that Python <v3.10 has to be used, otherwise the required dependencies will fail to install.

Motivation and Context

  • Fixes the broken build for the dev containers

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this nasty issue!

@josesimoes josesimoes changed the title Fixing dev containers with change in python version and new IDF version Fixing dev containers regarding Python version Jul 17, 2023
@josesimoes josesimoes merged commit 33477b4 into main Jul 17, 2023
7 checks passed
@josesimoes josesimoes deleted the fix-containers branch July 17, 2023 18:17
josesimoes pushed a commit to Eclo/nf-interpreter that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants