Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in Profiler code #2723

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Fixes in Profiler code #2723

merged 4 commits into from
Aug 24, 2023

Conversation

antoniofagundes
Copy link
Member

@antoniofagundes antoniofagundes commented Aug 24, 2023

Description

  • Fix missing return value in debugger profiling command.
  • Fix switch case fall-through in profiler.
  • Fix RTM build for Profiler::DumpRoot.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

- Fix missing return value in debugger profiling command.
- Fix switch case fall-through in profiler.
@antoniofagundes antoniofagundes added the Area: Common libs Everything related with common libraries label Aug 24, 2023
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes enabled auto-merge (squash) August 24, 2023 14:58
antoniofagundes and others added 3 commits August 24, 2023 16:22
Automated fixes for code style.
…b5246-47de-473c-bb7b-5f16d8a2afab

Code style fixes for nanoframework/nf-interpreter PR#2723
@josesimoes josesimoes merged commit da742c1 into nanoframework:main Aug 24, 2023
24 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants