DateTime and TimeSpan are not handled as primitive types anymore

[josesimoes]

Description

• Remove these throughout the code base.
• Add DateTime::NewObject and rework code accordingly.
• Update data type lookup for DateTime and TimeSpan so they end up as being treated like value type types.

Motivation and Context

• Part of Heap compaction is not working Home#1354.

How Has This Been Tested?

• mscorlib unit tests.
• GC long run test.

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue with code or algorithm)
• New feature (non-breaking change which adds functionality to code)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dev Containers (changes related with Dev Containers, has no impact on code or features)
• Dependencies (update dependencies and changes associated, has no impact on code or features)
• Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

[Ellerbach]

Those are quite some changes. Is there any impact on any of the existing native code using those elements? I'm thinking of everywhere we are using TimeSpan and DateTime in the parameters of a function for example.

[josesimoes]

Those are quite some changes. Is there any impact on any of the existing native code using those elements? I'm thinking of everywhere we are using TimeSpan and DateTime in the parameters of a function for example.

Everything that was somehow impacted by this change has been taken care of and thoroughly tested.
At the end of the day this is completely transparent to the C# applications.

[Ellerbach]

My question was on the native side, not on the C# side where, it doesn't matter at all. I fully trust you that all has been tested :-) I just want to get an understanding if anything could be impacted somehow by side effect.

[josesimoes]

Answering your question above: no impact on the existing code, apart from what was already changed to accommodate these changes.