Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mbed TLS to v3.6.0 #2992

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Update Mbed TLS to v3.6.0 #2992

merged 1 commit into from
Jul 30, 2024

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jul 30, 2024 •
edited by coderabbitai bot
Loading

Description

  • Update CMake.
  • Update dev containers and bump versions.
  • Add new API required by Mbed TLS for time base.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

  • New Features

    • Introduced a new function for converting Unix epoch time to milliseconds, enhancing precision for timing and logging applications.

  • Improvements

    • Updated the base images in various Dockerfiles, potentially improving performance, security, and introducing new features across development environments.
    • Upgraded the mbedtls library version across multiple Dockerfiles, bringing new features and bug fixes.

  • Bug Fixes

    • Downgraded the base image for FreeRTOS-NXP, addressing compatibility issues with the previous version.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 30, 2024 •
edited
Loading

Walkthrough

The recent updates mainly involve version upgrades for various Dockerfiles and the mbedtls library across different development containers. Base images have been updated to improve security and performance. The mbedtls library version has been upgraded from 3.5.2 to 3.6.0, potentially introducing new features and bug fixes. Additionally, a new function was added to enhance timing precision. Overall, these changes refine the development environment without altering existing functionality.

Changes

Files (Group) Change Summary
.devcontainer/All/Dockerfile.All Updated base image from v2.50 to v2.51.
.devcontainer/All/Dockerfile.All.SRC Updated mbedtls version from 3.5.2 to 3.6.0.
.devcontainer/AzureRTOS/Dockerfile.AzureRTOS Updated base image from v1.28 to v1.29.
.devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC Updated mbedtls version from 3.5.2 to 3.6.0.
.devcontainer/ChibiOS/Dockerfile.ChibiOS Updated base image from v1.29 to v1.30.
.devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC Updated mbedtls version from 3.5.2 to 3.6.0.
.devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP Downgraded base image from v1.02 to v1.01.
.devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP.SRC Updated mbedtls version from 3.5.2 to 3.6.0.
CMake/binutils.common.cmake Updated Mbed TLS library version tag from 3.5.2 to 3.6.0.
src/PAL/COM/sockets/ssl/MbedTLS/ssl_generic.cpp Introduced new function mbedtls_ms_time to convert Unix epoch time from seconds to milliseconds.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nfbot nfbot added the Type: dependencies Pull requests that update a dependency file(s) or version label Jul 30, 2024
@josesimoes josesimoes added Platform: STM32 Everything related specifically with ChibiOS platform Platform: NXP Everything related specifically with FreeRTOS Platform: ESP32 Everything related specifically with ESP32 platform labels Jul 30, 2024
@josesimoes
Update Mbed TLS to v3.6.0
53ccc2b 
- Update CMake.
- Update dev containers and bump versions.
- Add new API required by Mbed TLS for time base.
coderabbitai[bot]
coderabbitai bot reviewed Jul 30, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ab76b7f and e52f993.

Files selected for processing (11)
  • .devcontainer/All/Dockerfile.All (1 hunks)
  • .devcontainer/All/Dockerfile.All.SRC (1 hunks)
  • .devcontainer/All/scripts/git-pull-repos.sh (1 hunks)
  • .devcontainer/AzureRTOS/Dockerfile.AzureRTOS (1 hunks)
  • .devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC (1 hunks)
  • .devcontainer/ChibiOS/Dockerfile.ChibiOS (1 hunks)
  • .devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC (1 hunks)
  • .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP (1 hunks)
  • .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP.SRC (1 hunks)
  • CMake/binutils.common.cmake (1 hunks)
  • src/PAL/COM/sockets/ssl/MbedTLS/ssl_generic.cpp (1 hunks)
Files skipped from review due to trivial changes (4)
  • .devcontainer/All/Dockerfile.All
  • .devcontainer/AzureRTOS/Dockerfile.AzureRTOS
  • .devcontainer/ChibiOS/Dockerfile.ChibiOS
  • CMake/binutils.common.cmake
Additional comments not posted (7)
.devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP (1)

1-1: Verify the reason for downgrading the base image version.

Downgrading from v1.02 to v1.01 may reintroduce bugs or security issues that were fixed in the newer version. Ensure this change is intentional and won't negatively impact the development environment.

.devcontainer/All/scripts/git-pull-repos.sh (1)

18-18: Verify compatibility with the new mbedtls version.

Upgrading from mbedtls-3.5.2 to mbedtls-3.6.0 may introduce new features, bug fixes, or breaking changes. Ensure that the rest of the codebase is compatible with this new version and that any necessary adjustments are made.

.devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP.SRC (1)

58-58: Verify compatibility with the new mbedtls version.

Upgrading from mbedtls-3.5.2 to mbedtls-3.6.0 may introduce new features, bug fixes, or breaking changes. Ensure that the rest of the codebase is compatible with this new version and that any necessary adjustments are made.

.devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC (1)

68-68: Verify compatibility with mbedtls 3.6.0.

Ensure that the new version of mbedtls (3.6.0) is compatible with the rest of the project and does not introduce any breaking changes.

.devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC (1)

70-70: Verify compatibility with mbedtls 3.6.0.

Ensure that the new version of mbedtls (3.6.0) is compatible with the rest of the project and does not introduce any breaking changes.

src/PAL/COM/sockets/ssl/MbedTLS/ssl_generic.cpp (1)

214-218: LGTM! Ensure the new function is tested.

The new function mbedtls_ms_time is straightforward and enhances functionality. Ensure that this function is properly tested.

.devcontainer/All/Dockerfile.All.SRC (1)

81-81: LGTM! Verify the compatibility of the new mbedtls version.

The update from mbedtls-3.5.2 to mbedtls-3.6.0 appears correct.

However, ensure that the new version is compatible with the rest of the development environment and does not introduce any breaking changes or new dependencies.

coderabbitai[bot]
coderabbitai bot reviewed Jul 30, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e52f993 and 53ccc2b.

Files selected for processing (11)
  • .devcontainer/All/Dockerfile.All (1 hunks)
  • .devcontainer/All/Dockerfile.All.SRC (1 hunks)
  • .devcontainer/All/scripts/git-pull-repos.sh (1 hunks)
  • .devcontainer/AzureRTOS/Dockerfile.AzureRTOS (1 hunks)
  • .devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC (1 hunks)
  • .devcontainer/ChibiOS/Dockerfile.ChibiOS (1 hunks)
  • .devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC (1 hunks)
  • .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP (1 hunks)
  • .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP.SRC (1 hunks)
  • CMake/binutils.common.cmake (1 hunks)
  • src/PAL/COM/sockets/ssl/MbedTLS/ssl_generic.cpp (1 hunks)
Files skipped from review due to trivial changes (3)
  • .devcontainer/AzureRTOS/Dockerfile.AzureRTOS
  • .devcontainer/ChibiOS/Dockerfile.ChibiOS
  • CMake/binutils.common.cmake
Files skipped from review as they are similar to previous changes (8)
  • .devcontainer/All/Dockerfile.All
  • .devcontainer/All/Dockerfile.All.SRC
  • .devcontainer/All/scripts/git-pull-repos.sh
  • .devcontainer/AzureRTOS/Dockerfile.AzureRTOS.SRC
  • .devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC
  • .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP
  • .devcontainer/FreeRTOS-NXP/Dockerfile.FreeRTOS-NXP.SRC
  • src/PAL/COM/sockets/ssl/MbedTLS/ssl_generic.cpp

@josesimoes josesimoes merged commit fe88b98 into nanoframework:main Jul 30, 2024
34 of 38 checks passed
@josesimoes josesimoes deleted the update-mbedtls branch July 30, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

Assignees
No one assigned
Labels
Platform: ESP32 Everything related specifically with ESP32 platform Platform: NXP Everything related specifically with FreeRTOS Platform: STM32 Everything related specifically with ChibiOS platform Type: dependencies Pull requests that update a dependency file(s) or version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot