Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework bool functions and args #539

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

josesimoes
Copy link
Member

Description

  • Replace return types and arguments from bool by int on functions used in C and C++

Motivation and Context

  • This was causing compiler warnings becuase of C code being called by C++ code

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- This was causing compiler warnings becuase of C code being called by C++ code

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets Type: enhancement labels Dec 13, 2017
@nfbot
Copy link
Member

nfbot commented Dec 13, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 1794fe3 into nanoframework:develop Dec 13, 2017
@josesimoes josesimoes deleted the rework-bool-warning branch December 13, 2017 11:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants