Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OS Task priority for ReceiverThread #724

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Change OS Task priority for ReceiverThread #724

merged 1 commit into from
Jun 5, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Having the same priority as the CLR makes the USB communication smoother and allows the debugger to connect
  • Remove the PLATFORM_WAIT "hack" from MonitorReboot command
  • Remove PLATFORM_WAIT from targetHAL on all platforms

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Change OS Task priority for ReceiverThread
acdc0aa 
- Having the same priority as the CLR makes the USB communication smoother and allows the debugger to connect
- Remove the PLATFORM_WAIT hack from MonitorReboot command
- Remove PLATFORM_WAIT from targetHAL on all platforms

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets labels Jun 5, 2018
@nfbot
Copy link
Member

nfbot commented Jun 5, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

AdrianSoundy
AdrianSoundy approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@AdrianSoundy AdrianSoundy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK this removes the delay and changes the task priority.
I am happy to go with this so we can do more testing.
Recent changes to VS extension have also helped.

@AdrianSoundy AdrianSoundy merged commit 95855af into nanoframework:develop Jun 5, 2018
@josesimoes josesimoes deleted the fix-338 branch June 5, 2018 13:16
This was referenced Jun 5, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianSoundy AdrianSoundy AdrianSoundy approved these changes

@MatthiasJentsch MatthiasJentsch Awaiting requested review from MatthiasJentsch

Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to review the "pause" at the end of the Monitor_Reboot
3 participants
@josesimoes @nfbot @AdrianSoundy