Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on compiler warnings 🚧 #739

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Work on compiler warnings 🚧 #739

merged 1 commit into from
Jun 7, 2018

Conversation

josesimoes
Copy link
Member

⚠️ WORK IN PROGRESS ⚠️

Description

  • Various fixes with:
    • unused or misplaced arguments
    • bad or missing declarations
    • vars not initialized

Motivation and Context

  • This is part of major code rework on removing compiler warnings, requires testing

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Work on compiler warnings
3ab2029 
- Various fixes with:
  + unused or misplaced arguments
  + bad or missing declarations
  + vars not initialized

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Jun 7, 2018
@nfbot
Copy link
Member

nfbot commented Jun 7, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 7a3fc00 into nanoframework:develop Jun 7, 2018
@josesimoes josesimoes deleted the various-fixes branch June 7, 2018 15:12
josesimoes added a commit that referenced this pull request Jun 7, 2018
@josesimoes
Work on compiler warnings (#739)
36d1958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot