Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix I2c issues #803

Merged
merged 2 commits into from
Jul 23, 2018
Merged

Fix I2c issues #803

merged 2 commits into from
Jul 23, 2018

Conversation

AdrianSoundy
Copy link
Member

Description

Multiple device per bus now supported
Not returning I2cTransferResult correctly

Test

Tested with Oled display and 74LC256 on same bus

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@AdrianSoundy
Fix I2c issues
9a3b095 
Multiple device per bus now supported
Not returning I2cTransferResult correctly
@nfbot
Copy link
Member

nfbot commented Jul 23, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: bug Series: ESP32 Everything related specifically with ESP32 series targets labels Jul 23, 2018
josesimoes
josesimoes approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit f51081e into nanoframework:develop Jul 23, 2018
@AdrianSoundy AdrianSoundy deleted the develop-i2c-fix branch July 25, 2018 21:58
josesimoes pushed a commit that referenced this pull request Jul 27, 2018
@AdrianSoundy @josesimoes
Fix I2C issues in ESP32 (#803)
07fff78
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes