Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Base64 encoding/decoding #934

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Implemented Base64 encoding/decoding #934

merged 2 commits into from
Oct 23, 2018

Conversation

sjmneves
Copy link
Contributor

Description

  • Add helper function with mbedTLS signature allowing those to be replaced for targets that include it.
  • Update CMake accordingly.

Motivation and Context

How Has This Been Tested?

  • Convert.Base64 app from samples repo.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: sjmneves sjmneves@users.noreply.github.com

@sjmneves
Implemented Base64 encoding/decoding
c492886 
- Add helper function with mbedTLS signature allowing those to be replaced for targets that include it.
- Update CMake accordingly.
@nfbot
Copy link
Member

nfbot commented Oct 23, 2018

Hi @sjmneves,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such labels Oct 23, 2018
@josesimoes josesimoes merged commit a41371c into nanoframework:develop Oct 23, 2018
@josesimoes josesimoes deleted the Work-128 branch November 14, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add native implementation of Base64 encode and decode
4 participants
@sjmneves @nfbot @CLAassistant @josesimoes