Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in lcprimitives.py #1416

Closed
abhisrkckl opened this issue Oct 10, 2022 · 2 comments · Fixed by #1455
Closed

Bug in lcprimitives.py #1416

abhisrkckl opened this issue Oct 10, 2022 · 2 comments · Fixed by #1455

Comments

@abhisrkckl
Copy link
Contributor

abhisrkckl commented Oct 10, 2022

There is an undefined variable "x0" in the LCKernelDensity.integrate function.
image

It seems line no 1312 is using x0 and x1 instead of x1 and x2.

I am not sure how to trigger this. I came across this during a code cleanup operation.

@dlakaplan
Copy link
Contributor

I don't think I've ever used this module. Maybe @kerrm knows more?

@kerrm
Copy link
Contributor

kerrm commented Oct 11, 2022

Oof -- thanks for pointing it out, but this code is specific to Fermi timing stuff, and not really for wider use. I am working on a big PR now, and can't really recommend it for scrutiny by others.

This particular bit of code is quite old and certainly a candidate for removal.

@abhisrkckl abhisrkckl linked a pull request Nov 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants