Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edep templates #1455

Merged
merged 13 commits into from
Nov 30, 2022
Merged

Edep templates #1455

merged 13 commits into from
Nov 30, 2022

Conversation

kerrm
Copy link
Contributor

@kerrm kerrm commented Nov 22, 2022

This PR only affects the code used for managing Fermi pulse profiles. It

  1. Primarily adds the capability to model and fit energy evolution of pulse profile components.
  2. Re-works the older capability to do this to a cleaner interface.
  3. Removes some kruft.
  4. Substantially improves test coverage for old and new code. (I hope!)

@paulray
Copy link
Member

paulray commented Nov 22, 2022

Will this fix #1416 as well?

@kerrm
Copy link
Contributor Author

kerrm commented Nov 22, 2022 via email

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 64.30% // Head: 65.33% // Increases project coverage by +1.03% 🎉

Coverage data is based on head (8a7ffe6) compared to base (b43dbf4).
Patch coverage: 59.45% of modified lines in pull request are covered.

❗ Current head 8a7ffe6 differs from pull request most recent head 71e6863. Consider uploading reports for the commit 71e6863 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1455      +/-   ##
==========================================
+ Coverage   64.30%   65.33%   +1.03%     
==========================================
  Files          89       91       +2     
  Lines       20638    21266     +628     
  Branches     3558     3666     +108     
==========================================
+ Hits        13272    13895     +623     
+ Misses       6549     6519      -30     
- Partials      817      852      +35     
Impacted Files Coverage Δ
src/pint/templates/lcfitters.py 26.90% <33.20%> (+2.39%) ⬆️
src/pint/templates/lcprimitives.py 40.62% <54.72%> (+12.49%) ⬆️
src/pint/templates/lceprimitives.py 60.12% <60.12%> (ø)
src/pint/templates/lcnorm.py 56.94% <74.43%> (+9.60%) ⬆️
src/pint/templates/lctemplate.py 53.64% <75.70%> (+25.16%) ⬆️
src/pint/templates/lcenorm.py 75.94% <75.94%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlakaplan
Copy link
Contributor

Do you think it would be possible to include some PINT tutorials on Fermi and/or NICER data (something that is pure photons)? Maybe they exist elsewhere and just need links, but it could be helpful for others.

@kerrm
Copy link
Contributor Author

kerrm commented Nov 22, 2022

That's a good idea, but I don't have anything handy! I could work up something basic (in a different PR). If we want to include sample data sets, what's the best mechanism for that? I have some very small ones in the test directory, so perhaps I could use that.

@abhisrkckl abhisrkckl linked an issue Nov 22, 2022 that may be closed by this pull request
@paulray paulray merged commit fbf96c6 into nanograv:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in lcprimitives.py
3 participants