Fixed units on errors in fake TOAs #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1653 +/- ##
==========================================
- Coverage 68.33% 68.33% -0.01%
==========================================
Files 104 104
Lines 24112 24110 -2
Branches 4280 4280
==========================================
- Hits 16478 16476 -2
Misses 6549 6549
Partials 1085 1085
☔ View full report in Codecov by Sentry. |
dlakaplan
added
the
awaiting review
abhisrkckl
reviewed
Oct 18, 2023
|
This looks good to me. Shall I merge this? |
|
Yes, I think this is small & ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
make_fake_toas_uniformwould ignore the units on the errors that were passed (instead, us were assumed). I think this fixes that.