get_observatory shouldn't overwrite include_bipm and include_gps unless given explicitly
#1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1711 +/- ##
==========================================
+ Coverage 68.77% 68.78% +0.01%
==========================================
Files 105 105
Lines 24644 24643 -1
Branches 4407 4409 +2
==========================================
+ Hits 16948 16950 +2
+ Misses 6590 6588 -2
+ Partials 1106 1105 -1 ☔ View full report in Codecov by Sentry. |
abhisrkckl
added
the
awaiting review
abhisrkckl
commented
Jan 17, 2024
paulray
approved these changes
Jan 18, 2024
CHANGELOG-unreleased.md
Outdated
| @@ -40,4 +40,5 @@ the released changes. | |||
| - Consistent naming in `TimingModel.get_params_mapping()` | |||
| - Better exceptions for unsupported/unimplemented binary models (BTX, MSS, etc.) | |||
| - Emit warnings when `WaveX`/`DMWaveX` is used together with other representations of red/DM noise | |||
| - `get_observatory()` no longer overwrites `include_gps` and `include_bipm` of `Observatory` objects unless explicitly stated. | |||
There was a problem hiding this comment.
I think we should add "Fixes issue #1691 (BIPM+GPS clock corrections incorrectly applied to BAT TOAs)"
|
@paulray Can you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1691 is a symptom of this, although the root cause is elsewhere.
#1707 was an attempt at fixing this.
Related issue - #1708