-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Astrometry
& SolarSystemShapiro
faster
#1748
Conversation
PerformanceHere is the profiling code:
Before: 13.3 ms ± 45 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) After: 5.5 ms ± 33.4 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) |
I think this looks good. Is any explicit new testing required, or is the fact that all of the usual tests passed here sufficient (I suspect the latter since you haven't yet changed the precision)? Any changes wrt skipping the SkyCoord creation that need tests? |
I think the existing tests are sufficient. |
So I can merge? |
Yes. |
Avoid creating
SkyCoord
objects duringAstrometry
computations. This was partly implemented in #1646 for models with proper motion. This PR does the same thing for cases without proper motion. This has a significant performance advantage.The tests introduced by #1646 also cover these changes.
In
SolarSystemShapiro
, avoid doing expensive and unnecessary slices of theTOAs
table.Spun off from #1743, to make testing easier.