Fix the repeat nni_pipe in reap_pipe_list. #706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an error in handling clean session. The cache flags was set to false because the second pipe with same clientid was starting while the process of closing pipe is unfinished yet. Signed-off-by: wanghaemq <wangwei@emqx.io>
|
#707. This PR should be better and no memory leakage would happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an error in handling clean-session. The cache flag was set to false
because the second pipe with the same clientid was starting while the process of
closing first pipe is unfinished yet.
Which makes NanoMQ not crash when running the fuzz in nanomq/nanomq#1411. But memory leakage may happen.