Skip to content

Commit

Permalink
Merge branch 'DOR-967_increase_timeout_to_120_seconds' into 'master'
Browse files Browse the repository at this point in the history
DOR-967 Change high-latency batch timeout to 120 seconds

Closes DOR-967

See merge request machine-learning/dorado!1282
  • Loading branch information
kdolan1973 committed Nov 26, 2024
2 parents 154630a + 20e3ee4 commit c397f72
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions dorado/basecall/CudaCaller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ namespace dorado::basecall {

static constexpr float GB = 1.0e9f;

// Default value for timeout for incomplete batches. Large value of 30 seconds is
// found to give good results with mixtures of short and long reads.
static constexpr int DEFAULT_BATCH_TIMEOUT_MS = 30000;
// Default value for timeout for incomplete batches. Large value of 120 seconds is
// needed to avoid issues with performance benchmarking. A better solution is being
// worked on in DOR-968.
static constexpr int DEFAULT_BATCH_TIMEOUT_MS = 120000;

// Default value for timeout of incomplete batches for low-latency pipelines. The
// value of 350 ms has been found to give good adaptive-sampling performance on all
Expand Down

0 comments on commit c397f72

Please sign in to comment.