Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate completions into Homebrew formula #168

Closed
trallnag opened this issue Aug 9, 2024 · 2 comments
Closed

Integrate completions into Homebrew formula #168

trallnag opened this issue Aug 9, 2024 · 2 comments

Comments

@trallnag
Copy link

trallnag commented Aug 9, 2024

Is your feature request related to a problem?

Currently completions are not part of formula and have to be set up seperately.

Note that it is not really a problem for me. Just an idea for improvement.

Describe the solution you'd like

Integrate completions into Homebrew formula

Additional context

Homebrew supports completions in formulae.

Goreleaser supports completions. It is described well in this article: https://carlosbecker.com/posts/golang-completions-cobra/
nao1215 added a commit that referenced this issue Aug 10, 2024
@nao1215
Feat: Integrate completions into Homebrew formula (Issue #168)
406d3a8
@nao1215 nao1215 mentioned this issue Aug 10, 2024
Merged
nao1215 added a commit that referenced this issue Aug 10, 2024
@nao1215
Merge pull request #169 from nao1215/nchika/shipping-completion
86c37d1 
Feat: Integrate completions into Homebrew formula (Issue #168)
@nao1215
Copy link
Owner

nao1215 commented Aug 10, 2024

@trallnag
Thank you for your suggestion.
The feature you suggested has been introduced in v0.27.4

@trallnag
Copy link
Author

nice, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nao1215 @trallnag