New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve windows ux #113

Merged

nao1215 merged 1 commit into nao1215:main from lincolnthalles:improve-windows-ux

Oct 16, 2023

Contributor

lincolnthalles commented Oct 14, 2023

gup requires you to type the full binary name under Windows, which is a little annoying.
At first, I thought it was an issue with GOPATH.

> gup update buf
gup:WARN : not found 'buf' package in $GOPATH/bin or $GOBIN
gup:ERROR: unable to update package: no package information or no package under $GOBIN

> gup update buf.exe
gup:INFO : update binary under $GOPATH/bin or $GOBIN
gup:INFO : [1/1] github.com/bufbuild/buf/cmd/buf (Already up-to-date: v1.27.0)

This PR:

Improves bug-report command: launch in default browser instead of forcing msedge.
Makes possible to use gup update buf, gup update buf.exe and even mix syntaxes:

.\gup.exe update buf.exe goreleaser
gup:INFO : update binary under $GOPATH/bin or $GOBIN
gup:INFO : [1/2] github.com/bufbuild/buf/cmd/buf (Already up-to-date: v1.27.0)
gup:INFO : [2/2] github.com/goreleaser/goreleaser (Already up-to-date: v1.21.2)


          chore: improve windows ux

e353cd0

Owner

nao1215 commented Oct 16, 2023

@lincolnthalles

Thank you for the pull request.
I intend to merge the PR once the tests pass. good improvement.

nao1215 merged commit cd1cf92 into nao1215:main

12 of 13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet