Add default openBrowser function #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All systems other than Darwin, Linux, and Windows fail to build gup due to a missing openBrowser function. The addition of a default openBrowser function for those other systems allows gup to continue building on other platforms like the BSDs, directing users to open the bug report URL in their preferred browser.
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 82.84% 82.84%
=======================================
Files 15 15
Lines 688 688
=======================================
Hits 570 570
Misses 87 87
Partials 31 31 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@memreflect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All platforms other than Darwin, Linux, and Windows fail to build gup due to a missing openBrowser function.
This commit adds a default openBrowser function for those other systems to allow gup to build on other platforms like the BSDs, directing users to open the bug report URL in their preferred browser as intended.