Split msg generation from driver nodes for Humble #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't been able to keep up with the latest ROS2 releases, so I really appreciate your help! I'll take a look at it later today, thanks! |
|
Thanks for your PR! I was able to test the demo script on a docker environment. I did move the docker directory to the root (plus the |
|
Oh awesome, that was quick! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got errors when trying to build with ROS 2 Humble, and realized that calling rosidl_generate_interfaces and ament_python_install_package in the same package does not work.
So, I split up the message generation into a separate package.
References:
ros2/rosidl_python#141
https://docs.ros.org/en/humble/How-To-Guides/Ament-CMake-Python-Documentation.html
Functionality is as expected, but I have not tested the docker scripts (since I do not have experience there). @naoki-mizuno could you please review the docker part? Are any changes needed in the .bash script? Is the docker directory in the correct place, or should it be in the root directory?
I would prefer to have these changes in a new humble-devel branch, but it should work perfectly well on foxy.