Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct version in podspec #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fiznool
Copy link

@fiznool fiznool commented Jan 18, 2018

Sets the version defined by the podspec according to that in package.json.

I don't know very much about cocoapods but might this be a fix for #82? Surely it can't be this simple though 😄

@koenpunt
Copy link
Collaborator

Something like this was what I intended for #82, but there’s a syntax error


Pod::Spec.new do |s|
s.name = "react-native-safari-view"
s.version = "1.0.0"
s.version = "package['version']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the should not be

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, of course 🤦‍♂️

@reimertz
Copy link

First, thanks @naoufal and contributors for all the hard work, secondly, any reason we don't merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants