Fix command checking of echo in _gen_rollback_cfg #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix generated pattern for command "copy running-config ..." in _gen_rollback_cfg. The command has to be explicit in the full form "copy running-configuration ..." to avoid breakage when the command echo (which is full form in case of OS10 10.5.1.3) is compared with the short form patern and fails the check. The resulting exception was: netmiko.ssh_exception.NetmikoTimeoutException: Timed-out reading channel, data not available.
|
@javeedf Can you release a new version that includes this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix generated pattern for command "copy running-config ..." in
_gen_rollback_cfg. The command has to be explicit in the full form
"copy running-configuration ..." to avoid breakage when the command
echo (which is full form in case of OS10 10.5.1.3) is compared with
the short form patern and fails the check.
The resulting exception was:
netmiko.ssh_exception.NetmikoTimeoutException: Timed-out reading
channel, data not available.
This fixes issue #24