support load_replace_candidate function ,add implemented functions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… README file and add requirments
|
@samerd please review |
samerd
requested changes
Oct 28, 2019
There was a problem hiding this comment.
Thanks @anas-shami
missing unit-tests for the added commands
| output = self._send_command(command) | ||
| bytes_free = '0' | ||
| matches = re.findall(r'Space Free\s+(\d+) MB', output) | ||
| if matches and len(matches) >= 2: |
There was a problem hiding this comment.
not a good solution
what is a new fs added in the future or /config removed.
it would be better to use json and choose the one with the /var
There was a problem hiding this comment.
yes but even the json is not giving me any mapping, some thing like this
{
"Space Free": "7989 MB",
"Space Used": "1889 MB",
"Space Percent Free": "80%",
"header": "Statistics for /var filesystem",
"Space Available": "7481 MB",
"Inodes Percent Free": "99%",
"Space Total": "9878 MB"
}
may I check the header attribute if this object.header contains ('/var') take free size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support load_replace_candidate function, add implemented functions to README file and add requirements (paramiko, SCPClient)
load_replace_candidate: load config remotely without running it on the switch.