lxml text retrieval (find_txt) shouldn't fail if no text element available #1242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers,
I propose to enhance the
find_txt
function so it won't log an error when it tries to get the text out of the element that has no text element present.Consider the following example:
In the XML snippet above, the current
find_txt
behaviour will log an error if one tries to get the text out of the element with not text value (secondprint
func):The proposed PR adds additional conditional branch to not try to get the text value from a None object. Which will result in a clean execution:
# python run_new_find_txt.py element with text value: up element with no text value: default_value