-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Junos get_lldp_neighbor port returns the port-id, not the port-decription #1470
Junos get_lldp_neighbor port returns the port-id, not the port-decription #1470
Conversation
@@ -104,7 +104,7 @@ junos_lldp_table: | |||
junos_lldp_view: | |||
fields: | |||
hostname: lldp-remote-system-name | |||
port: lldp-remote-port-description | lldp-remote-port-id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lldp-remote-port-description
needs to stay as that's what older Junos versions provide.
I left a suggested change, in order to avoid breaking the behaviour for older Junos. I'll also ask you to provide an additional test case (or rename the existing on to something like |
Co-authored-by: Mircea Ulinic <mirceaulinic@users.noreply.github.com>
@mirceaulinic , after reviewing the logic, I decided to implement a small change on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chadell!
While working with
get_lldp_neighbors
forjunos
I noticed that the return value forport
was misleading (at least for me), being actually theport-description
instead the expectedport-id
.I understand this could be a breaking change, so opening this PR to get feedback on this proposed change.