Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the issue with the updated json output in newer versions of NXOS. #1490

Merged
merged 5 commits into from
Oct 14, 2021
Merged

Fixing the issue with the updated json output in newer versions of NXOS. #1490

merged 5 commits into from
Oct 14, 2021

Conversation

thomasbridge74
Copy link
Contributor

This addresses the issue found in #1489 .

mirceaulinic
mirceaulinic approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Could you also add a test case for this issue please?

@thomasbridge74
Copy link
Contributor Author

@mirceaulinic I've added two tests as requested. One covers the scenario where the vlanshowbr-vlanid string is not the same as the vlanshowbr-vlanid-utf string and one covers a scenario where the vlanshowbr-vlanid-utf is not received (which may be the case in older versions of Arista, I'm not sure).

mirceaulinic
mirceaulinic approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks @thomasbridge74!

@mirceaulinic mirceaulinic added this to the 3.4.0 milestone Oct 14, 2021
@mirceaulinic mirceaulinic merged commit 48a73ef into napalm-automation:develop Oct 14, 2021
@mirceaulinic mirceaulinic mentioned this pull request May 20, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
bug get_vlans nxos-ssh vendor bug
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasbridge74 @mirceaulinic