Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.rst #247

Merged
merged 2 commits into from
May 11, 2016
Merged

Update index.rst #247

merged 2 commits into from
May 11, 2016

Conversation

Jaredn
Copy link
Contributor

@Jaredn Jaredn commented May 11, 2016

Documented nxos_protocol optional argument (Open PR in Napalm-nxos)

Documented nxos_protocol optional argument
@mirceaulinic
Copy link
Member

Reference the PR from napalm-nxos please

@@ -138,6 +138,7 @@ ____________________________________
* :code:`dest_file_system` (ios) - Destination file system for SCP transfers (default: 'flash:').
* :code:`auto_rollback_on_error` (ios) - Disable automatic rollback (certain versions of IOS support configure replace, but not rollback on error) (default: True).
* :code:`global_delay_factor` (ios) - Allow for additional delay in command execution (default: .5).
* :code:`nxos_protocol` (nxos) - Protocol to connect with. Example: 'https' (default: 'http').
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably specify that you can only choose between http and https.

Updated language around supported arguments for nxos_protocol per PR comments.
@Jaredn
Copy link
Contributor Author

Jaredn commented May 11, 2016

Updates made. napalm-nxos PR supporting this: napalm-automation/napalm-nxos#9

@dbarrosop dbarrosop merged commit e3a4367 into napalm-automation:master May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants