Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bad clitools entry point. #250

Merged
merged 1 commit into from
May 12, 2016
Merged

Remove bad clitools entry point. #250

merged 1 commit into from
May 12, 2016

Conversation

jzohrab
Copy link
Contributor

@jzohrab jzohrab commented May 11, 2016

clitools has moved to napalm_base module.

Proposed fix for part of #249

I didn't bump the version, I assume that the maintainers do that.

clitools has moved to napalm_base module.
@@ -25,10 +25,5 @@
],
url="https://github.com/napalm-automation/napalm",
include_package_data=True,
install_requires=reqs,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this line : )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbarrosop: It's below, I just removed the comma.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you mean the line needs to have the comma after it - a style issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just missed it : )

@dbarrosop dbarrosop added the bug label May 12, 2016
@dbarrosop dbarrosop added this to the 1.0.2 milestone May 12, 2016
@dbarrosop dbarrosop merged commit 346155a into napalm-automation:develop May 12, 2016
dbarrosop pushed a commit that referenced this pull request Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants