-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conf.py to display the announcement banner #342
Conversation
Hmm, anyone else seeing this? On Firefox, the link target for the survey link is just a few pixels tall: Screen.Recording.2024-01-31.at.10.46.34.pm.movFine on Safari and Chrome. I don't think it has anything to do with this PR and everything to do with the theme, so I don't think we should hold this up to investigate. (I still managed to click it 😂 and I think Firefox users are a persistent bunch! 😂) |
@Czaki that is this note:
I will make the separate PR, but the permanent fix is napari/napari-sphinx-theme#145, which is in v0.3.2 (released, but not updated in pins). |
Yes, just wanted to make sure you had multiple options at hand before I went to bed. 😊 Feel free to close #344 if it gets fixed! But this one should get merged/backported either way. 😅 |
Confirming, looks ok on my firefox/linux: firefox.mp4 |
References and relevant issues
Together with #341, this PR supersedes #332.
Description
The announcement banner text html was added in #341. This PR now points our
config to it, allowing the banner to be displayed.
Note: #332 also has a CSS fix. However, that fix is included in the latest
release of the napari-sphinx-theme, so I think it's best to leave it out of
this PR. (I would be happy to make a separate PR for it if we don't want to
wait until the dependencies are updated.)