Improve our 'Creating widgets' section #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
docs/howtos/extending/magicgui.md
Outdated
| [](magicgui-return-annotations) for information how to use `napari` types to add | ||
| output to the napari viewer. | ||
|
|
||
| Note all type annotations *require* that the resulting widget be added to a |
There was a problem hiding this comment.
What does this mean? Why does the widget have to be added to a viewer?
There was a problem hiding this comment.
This was definitely from Talley, and I wonder if it is a magicgui thing? Where the type annotation magic doesn't work until its added to a window? 🤷
There was a problem hiding this comment.
Amended, hopefully that is okay
|
Thank @DragaDoncila , I think I've addressed everything! |
DragaDoncila
approved these changes
Apr 18, 2024
psobolewskiPhD
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Follow on from #68
Description
create_widgetin any widget classmagicguifunction widgets as plugin contributions' to be next to the intro to magicgui function widgets