Fix frame capture when using PyQt6 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
approved these changes
Dec 16, 2024
|
@dalthviz following the references doesn't make it any clearer to me why this works. Do you have any intuition there? |
|
(specifically: why does this help the Qt6 case but is unnecessary in Qt5-land?) |
|
As I understand, it is connected with some backward compatibility code introduced by qtpy. Something like: |
Exactly! 👍 |
|
I can confirm this fixes my issue with pyqt6. |
|
Brilliant. Thanks both! I've copied the explanation over to the PR description! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #40 (comment), #42 (comment)
These failures were caused by an intervening frame in QtPy when using the Qt6 backend, because QtPy replaced some removed functions in the Qt5->Qt6 transition with their own implementations:
https://github.com/spyder-ide/qtpy/blob/1d2a1eae43bda2a3d0efef605cafc5462389ec03/qtpy/QtWidgets.py#L69-L105
Therefore, when looking for "first frame in the call stack that is not in napari", the frame capture code would stop in QtPy. By adding QtPy to the list of ignored prefixes, this PR fixes the issue in the Qt6 case.