Initial napari specific classes for package installer related logic

[dalthviz]

Part of #59

[codecov]

Codecov Report

Attention: Patch coverage is 94.03409% with 21 lines in your changes missing coverage. Please review.

Project coverage is 94.07%. Comparing base (84f79a0) to head (b7faa65).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
napari_plugin_manager/base_qt_package_installer.py	92.95%	20 Missing ⚠️
napari_plugin_manager/qt_package_installer.py	92.85%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   93.53%   94.07%   +0.53%     
==========================================
  Files          11       13       +2     
  Lines        1981     2026      +45     
==========================================
+ Hits         1853     1906      +53     
+ Misses        128      120       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jaimergp]

LGTM but let's have @goanpeca take a look too before the merge.

[goanpeca]

Hi @dalthviz just went through the PR. Looks really good :)

Thanks for working on this.

Is there anything that can be tested from the base implementations as to have separate test files also?

test_base_qt_installer...
test_qt_installer...

?

[dalthviz]

Is there anything that can be tested from the base implementations as to have separate test files also?

test_base_qt_installer...
test_qt_installer...

?

Thinking about that maybe we could move

napari-plugin-manager/napari_plugin_manager/_tests/test_installer_process.py

Lines 58 to 70 in 84f79a0

	def test_not_implemented_methods():
	tool = AbstractInstallerTool('install', ['requests'])
	with pytest.raises(NotImplementedError):
	tool.executable()
	with pytest.raises(NotImplementedError):
	tool.arguments()
	with pytest.raises(NotImplementedError):
	tool.environment()
	with pytest.raises(NotImplementedError):
	tool.available()

to a test_base_qt_installer. Will do that change 👍

[jaimergp]

Looks like we have a reproducible error in the Windows CI 🤔

[dalthviz]

I think I was able to fix it by adding a qtbot.wait but let me know if something else is needed here!

[dalthviz]

Should we merge this now and proceed with releasing v0.1.4 @jaimergp @goanpeca ? Or something else is missing?

[goanpeca]

I have a couple of PRs that I will merge afterwards, but I can also make a new minor release anyway :)

So either way works for me

[dalthviz]

Oh I see, I think I will merge then this in an hour or so (if no other comment is added). Also, maybe we should list/mention those other pending PRs over #122 ? Makes sense to me to merge any pending work and just do one new release 🤔

[goanpeca]

Will work on those PRs today and will ping you back :)