Center event popover vertically #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the best way to test this? Clone docs, clone this, install from repo, build locally? |
|
Yeah, I think for the theme there's no other way. I could set up a preview action in circleCI like the others but I guess that's not super high priority right now. |
Czaki
added a commit
to napari/docs
that referenced
this pull request
Jan 31, 2024
# References and relevant issues Closes napari/napari-sphinx-theme#138, together with napari/napari-sphinx-theme#147 # Description Clicking outside of the calendar event modal or pressing the ESC key closes the modal. --------- Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Czaki
added a commit
to napari/napari
that referenced
this pull request
Jan 31, 2024
# References and relevant issues Closes napari/napari-sphinx-theme#138, together with napari/napari-sphinx-theme#147 # Description Clicking outside of the calendar event modal or pressing the ESC key closes the modal. --------- Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #138